Browse Source

Fix unnecessary break when calculating the height of visible lines

This break causes the minsize to be smaller than expected, and then
the size keeps increasing by one line to cover all visible lines.
This can cause performance issues when there are many visible lines.
Rindbee 2 years ago
parent
commit
e5bebbc9ff
1 changed files with 0 additions and 3 deletions
  1. 0 3
      scene/gui/label.cpp

+ 0 - 3
scene/gui/label.cpp

@@ -290,9 +290,6 @@ void Label::_update_visible() {
 	int last_line = MIN(lines_rid.size(), lines_visible + lines_skipped);
 	for (int64_t i = lines_skipped; i < last_line; i++) {
 		minsize.height += TS->shaped_text_get_size(lines_rid[i]).y + line_spacing;
-		if (minsize.height > (get_size().height - style->get_minimum_size().height + line_spacing)) {
-			break;
-		}
 	}
 }